Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce test time with a global LLM mock #685

Merged
merged 11 commits into from
Jan 5, 2024
Merged

Reduce test time with a global LLM mock #685

merged 11 commits into from
Jan 5, 2024

Conversation

garylin2099
Copy link
Collaborator

@garylin2099 garylin2099 commented Jan 4, 2024 •
edited
Loading

Features

  • Reduce test time to less than 15 mins
  • Almost all tests are mocked, meaning possible to automate run on every PR, which will be very useful to discover problems early
  • Responses from passed tests only, which we deem as expected LLM responses, are saved for future reuse.
  • Mock avoid providers folder which allows model APIs to be tested differently

Result
https://github.com/garylin2099/MetaGPT/actions/runs/7409829788/job/20160838711

Limitation
Still some failed tests (21 / 375, 6%), need to solve all of them for the tests to be of truly useful

geekan
geekan approved these changes Jan 5, 2024
View reviewed changes
Copy link
Owner

@geekan geekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geekan geekan merged commit 230192f into geekan:main Jan 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iorisa iorisa iorisa left review comments

@geekan geekan geekan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garylin2099 @geekan @iorisa